chore/VRF-325 - Added smoke test for direct funding on VRFv2

[dkneisly]

Added smoke tests for direct funding invoking randomness on VRFv2

[github-actions]

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

[ibrajer]

Why is everything commented out here? You uncomment and run a specific line only when you need it?

[iljapavlovs]

its just how it works, it should be commented out. check https://go.dev/blog/generate.

so //go:generate will be invoked when "go generate" cmd will be invoked from cli. Which in turn you need to invoke from make command - https://github.com/smartcontractkit/chainlink/blob/develop/contracts/GNUmakefile#L72C1-L72C1

So whenever you add a solidity contract or update it, you need to invoke make wrappers-all from contracts folder.

In case if you have added new contract, then afterwards you need to ensure that you have added the contracts' golang binding, in this case it's vrfv2_wrapper_load_test_consumer.go. you need to add it from git unversioned files

[ibrajer]

Is there a way to do assignment expressions in Go (assign the variable and check the condition in one line)? Or this is the standard way to do error handling in Go? Just curious if anyone knows... I have very little knowledge of Go.

[iljapavlovs]

I guess it would look smth like this:

	if err := env.EVMClient.WaitForEvents(); err != nil {
		return nil, nil, fmt.Errorf("%s, err %w", ErrWaitTXsComplete, err)
	}

but its matter of preference

[cl-sonarqube-production]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication