Replace mercury eventbroadcaster with polling #11707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
I see that you haven't updated any README files. Would it make sense to do so? |
krehermann
changed the title
krehermann
changed the title
krehermann
requested review from
samsondav,
sdrug and
martin-cll
as code owners
krehermann
requested review from
jmank88 and
samsondav
and removed request for
sdrug,
samsondav and
martin-cll
|
SonarQube Quality Gate
|
jmank88
approved these changes
Jan 8, 2024
samsondav
approved these changes
Jan 9, 2024
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussions with @samsondav : mercury does not need a custom config poller and can instead use the default libocr implementation, which polls at 15s intervals.
This change removes the custom implementation and thereby removed dependencies on the event broadcast and pg notify