Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add logging for vrf output #11719

Merged
merged 1 commit into from
Jan 10, 2024
Merged

add logging for vrf output #11719

merged 1 commit into from
Jan 10, 2024

Conversation

jinhoonbang
Copy link
Contributor

  • output from vrfv2 and vrfv2plus task can be used to manually fulfill requests older than 24 hours
  • output was downgraded to TRACE log as part of this PR https://github.com/smartcontractkit/chainlink/pull/9574/files
  • this PR adds new log statements so that output is logged and retained in Loki for 30 days

@jinhoonbang jinhoonbang requested a review from a team as a code owner January 9, 2024 22:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

I see that you haven't updated any README files. Would it make sense to do so?

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

ibrajer
ibrajer approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@ibrajer ibrajer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinhoonbang jinhoonbang added this pull request to the merge queue Jan 10, 2024
Merged via the queue into develop with commit f8bc7c6 Jan 10, 2024
80 checks passed
@jinhoonbang jinhoonbang deleted the add-logging-vrf-proof branch January 10, 2024 14:33
This was referenced Feb 22, 2024
Closed
Closed
@snehaagni snehaagni mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeyikjiun leeyikjiun leeyikjiun approved these changes

@ibrajer ibrajer ibrajer approved these changes

@kidambisrinivas kidambisrinivas kidambisrinivas approved these changes

@dkneisly dkneisly Awaiting requested review from dkneisly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jinhoonbang @kidambisrinivas @ibrajer @leeyikjiun