pipeline/task.bridge: do not cache invalid external adapter response objects. #11725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
brunotm
changed the title
brunotm
requested review from
connorwstein and
prashantkumar1982
as code owners
brunotm
changed the title
amit-momin
reviewed
Jan 10, 2024
brunotm
force-pushed
the
MERC-2650-update-bridge-task-response-handler-to-correctly-handle-provider-status-code-in-ea-responses
branch
from
849d862 to
ba7378e
Compare
amit-momin
previously approved these changes
Jan 10, 2024
jmank88
reviewed
Jan 12, 2024
brunotm
force-pushed
the
MERC-2650-update-bridge-task-response-handler-to-correctly-handle-provider-status-code-in-ea-responses
branch
from
3a8826f to
6208205
Compare
samsondav
approved these changes
Jan 17, 2024
brunotm
force-pushed
the
MERC-2650-update-bridge-task-response-handler-to-correctly-handle-provider-status-code-in-ea-responses
branch
from
b209212 to
7ad23eb
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
brunotm
force-pushed
the
MERC-2650-update-bridge-task-response-handler-to-correctly-handle-provider-status-code-in-ea-responses
branch
from
7ad23eb to
408746c
Compare
brunotm
force-pushed
the
MERC-2650-update-bridge-task-response-handler-to-correctly-handle-provider-status-code-in-ea-responses
branch
from
408746c to
0c64bb7
Compare
Co-authored-by: Jordan Krage <[email protected]>
brunotm
force-pushed
the
MERC-2650-update-bridge-task-response-handler-to-correctly-handle-provider-status-code-in-ea-responses
branch
from
0c64bb7 to
5d1351c
Compare
|
SonarQube Quality Gate
|
samsondav
deleted the
MERC-2650-update-bridge-task-response-handler-to-correctly-handle-provider-status-code-in-ea-responses
branch
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the task bridge to check the external adapter response object for invalid status code, provider status code and internal errors. Fixes the issues described on BCF-2415.
Aligned with the current behaviour for v2/v3 external adapters.