Rename external facing mercury to data streams #11754
Conversation
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
shileiwill
force-pushed
the
rename-to-data-streams
branch
from
78a065c to
764df4a
Compare
shileiwill
changed the title
| @@ -8,8 +8,8 @@ KEEPER_REGISTRY_ADDRESS=<Registry Address> | |||
| #TENDERLY_ACCOUNT_NAME=<Tenderly Account Name> | |||
| #TENDERLY_PROJECT_NAME=<Tenderly Project Name> | |||
|
|
|||
| # [Optional] add mercury info only if your upkeep uses mercury | |||
| #MERCURY_ID=<Mercury ID> | |||
There was a problem hiding this comment.
will we do these renaming in core nodes too?
if so, lots of node configs need to change too.
There was a problem hiding this comment.
you are right, there are a ton of mercury in our codebase.
The answer is no, at least at this point. in this PR, we are just changing the external facing names. For example, we expect users who use our debugging script will need to provide this Mercury_ID, hence renaming it.
| #DATA_STREAMS_ID=<DATA STREAMS ID> |
There was a problem hiding this comment.
Could we add a link here to the docs page on chainlink data streams?
core/scripts/chaincli/README.md
Outdated
| - `DATA_STREAMS_LEGACY_URL` | ||
| - `DATA_STREAMS_URL` |
There was a problem hiding this comment.
Could we add a little more explanation here about the difference between these two URLs? I'm not sure how easy it is for a customer to know if they are using the legacy version or not.
There was a problem hiding this comment.
Good point. I think LegacyURL points to mercury v0.2 server and URL points to mercury v0.3 server.
If we want to support only v0.3, then we may just get rid of the legacy URL. Let me double confirm. I will update with some explanation too!
shileiwill
force-pushed
the
rename-to-data-streams
branch
from
764df4a to
fe9d76c
Compare
shileiwill
force-pushed
the
rename-to-data-streams
branch
from
fe9d76c to
a822494
Compare
shileiwill
force-pushed
the
rename-to-data-streams
branch
from
491626a to
df98330
Compare
shileiwill
force-pushed
the
rename-to-data-streams
branch
from
df98330 to
49c70c4
Compare
|
SonarQube Quality Gate
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
AUTO-8376
As title, to avoid confusing our users, especially as we are releasing the debugging script, we want to be consistent on our naming. Here we rename all external facing mercury to data streams.
Testing: