VRF-780: updating VRF Owner contract; VRF-847: add posibility to deploy test coordinator, better customisation options for VRF job spec #11769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
iljapavlovs
commented
Jan 12, 2024
•
iljapavlovs
commented
- Better configurability for super scripts and ctf tests
- Adding vrf owner test
- Adding test coordinator to CTF and to super scripts for the env deployments
VRF-847: add posibility to deploy test coordinator, better customisation options for VRF job spec
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
…-adding-test-coordinator' into chore/VRF-780-updating-vrf-owner-adding-test-coordinator
iljapavlovs
requested review from
jkongie,
jmank88 and
samsondav
as code owners
dkneisly
previously approved these changes
Jan 23, 2024
| From: common.HexToAddress(v.client.GetDefaultWallet().Address()), | ||
| Context: ctx, | ||
| } | ||
| coordinatorOwnerAddres, err := v.coordinator.Owner(opts) |
There was a problem hiding this comment.
nit: missing second 's' in Address
…-adding-test-coordinator' into chore/VRF-780-updating-vrf-owner-adding-test-coordinator
|
SonarQube Quality Gate
|
dkneisly
approved these changes
Jan 23, 2024
iljapavlovs
deleted the
chore/VRF-780-updating-vrf-owner-adding-test-coordinator
branch
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.