Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old way of configuring telemetry pubkey and url #11780

Conversation

george-dorin
Copy link
Contributor

@george-dorin george-dorin commented Jan 15, 2024

Remove the old way of configuring TelemetryIngress.URL and TelemtryIngress.ServerPubKey.
Moving forward configuration should be done withing [[TelemetryIngress.Endpoints]]

Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@george-dorin george-dorin marked this pull request as ready for review January 17, 2024 11:22
@george-dorin george-dorin requested a review from jkongie as a code owner January 17, 2024 11:22
@george-dorin george-dorin requested a review from jmank88 January 17, 2024 11:22
patrickhuie19
patrickhuie19 previously approved these changes Jan 17, 2024
jmank88
jmank88 previously approved these changes Jan 17, 2024
@jmank88
Copy link
Contributor

jmank88 commented Jan 17, 2024

Do we need to update the changelog?

@george-dorin
Copy link
Contributor Author

Do we need to update the changelog?

Added in 8f686d3

@cl-sonarqube-production
Copy link

@george-dorin george-dorin added this pull request to the merge queue Jan 23, 2024
Merged via the queue into develop with commit 4b8988b Jan 23, 2024
84 checks passed
@george-dorin george-dorin deleted the chore/BCF-2723-remove-old-way-of-configurin-monitoring-endpoints branch January 23, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants