Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Grafana Logging for Live Testnets #11798

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Adds Grafana Logging for Live Testnets #11798

merged 4 commits into from
Jan 23, 2024

Conversation

kalverra
Copy link
Collaborator

No description provided.

@kalverra kalverra requested a review from Tofel January 17, 2024 13:22
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

Tofel
Tofel previously approved these changes Jan 17, 2024
View reviewed changes
Tofel
Tofel previously approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@Tofel Tofel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jmank88
jmank88 previously approved these changes Jan 17, 2024
View reviewed changes
@kalverra kalverra added this pull request to the merge queue Jan 17, 2024
@kalverra kalverra removed this pull request from the merge queue due to a manual request Jan 17, 2024
@kalverra kalverra dismissed stale reviews from jmank88 and Tofel via 59872c3 January 17, 2024 19:39
@kalverra kalverra requested a review from a team as a code owner January 17, 2024 19:39
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kalverra kalverra enabled auto-merge January 22, 2024 20:39
@kalverra kalverra added this pull request to the merge queue Jan 23, 2024
Merged via the queue into develop with commit 91c799c Jan 23, 2024
83 checks passed
@kalverra kalverra deleted the loggingLiveTests branch January 23, 2024 15:15
This was referenced Feb 22, 2024
Closed
Closed
@snehaagni snehaagni mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tofel Tofel Tofel approved these changes

@jmank88 jmank88 jmank88 left review comments

@chainchad chainchad Awaiting requested review from chainchad

@javuto javuto Awaiting requested review from javuto

@jkongie jkongie Awaiting requested review from jkongie

@samsondav samsondav Awaiting requested review from samsondav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalverra @jmank88 @Tofel