bump geth; replace common.Address.Hash() calls; restore standard log #11806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
jmank88
changed the title
jmank88
commented
Jan 18, 2024
| func init() { | ||
| // hack to undo geth's disruption of the std default logger | ||
| // remove with geth v1.13.10 | ||
| slog.SetDefault(slog.New(slog.NewTextHandler(os.Stderr, nil))) |
There was a problem hiding this comment.
Geth is registering a discard logger from an init that we have to replace to restore standard logs for goose, etc.: https://github.com/ethereum/go-ethereum/blob/38926cc6e507ba622275de789800e74215117dec/log/root.go#L13-L14
|
SonarQube Quality Gate
|
jmank88
requested review from
a team,
jkongie,
samsondav,
RyanRHall,
reductionista,
connorwstein and
prashantkumar1982
as code owners
reductionista
approved these changes
Jan 18, 2024
Merged
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I picked out some changes from #11799 to narrow down the issue over there.