-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor loop registry #11807
Closed
Closed
Refactor loop registry #11807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
requested review from
jmank88,
krehermann,
jkongie and
connorwstein
as code owners
January 18, 2024 12:07
I see that you haven't updated any README files. Would it make sense to do so? |
jmank88
previously approved these changes
Jan 18, 2024
krehermann
previously approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks better. thanks for cleaning it up
cedric-cordenier
dismissed stale reviews from krehermann and jmank88
via
January 19, 2024 12:37
0aa5bf2
cedric-cordenier
force-pushed
the
refactor-loop-registry
branch
from
January 19, 2024 12:47
0aa5bf2
to
68de7d6
Compare
cedric-cordenier
force-pushed
the
refactor-loop-registry
branch
from
January 19, 2024 13:01
68de7d6
to
968b23d
Compare
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was doing some exploration of the loop registry, I found the code to be hard to modify and quick tightly coupled together. This is my attempt to clean some of this up.
In particular, I:
This also makes it easier to add a handle to the loop into the registry at a later date if desirable.
@krehermann Please push back if there's something I'm missing