-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace multierr dep with stnd lib as much as possible #11818
Conversation
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
I see that you haven't updated any README files. Would it make sense to do so? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for your public service.
SonarQube Quality Gate Reliability Rating on New Code (is worse than A) See analysis details on SonarQube Fix issues before they fail your Quality Gate with SonarLint in your IDE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, do we have a plan for including stacktraces in the errors though? This can sometimes be very helpful
We haven't chosen a direct replacement to create an error with a trace, although logging at ERROR level or above will include one. |
This PR should only modify Multierr, which i dont think has stack traces with errors. It doesnt touch |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR aims to reduce the amount we use 3rd party pkgs
multierr.Combine
witherrors.Join
multierr.Append
witherrors.Join
multierr.AppendInto
witherrors.Join
github.com/pkg/errors
also exists topkgerrors
to prevent confusion with the standard library pkgNotes:
github.com/pkg/errors
in this pr... that might need more thought and buyinRelated: