Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document metrics renaming changes #11819

Closed

Conversation

dhaidashenko
Copy link
Collaborator

Due to migration to generalized MultiNode, some of the EVM Pool metrics were renamed to be more chain agnostic.

Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dhaidashenko dhaidashenko marked this pull request as ready for review January 19, 2024 12:12
@dhaidashenko dhaidashenko requested a review from jmank88 January 19, 2024 12:13
chudilka1
chudilka1 previously approved these changes Jan 19, 2024
@snehaagni
Copy link
Contributor

@dhaidashenko Could you please target this PR against release/2.8.0 instead of develop?

@dhaidashenko dhaidashenko force-pushed the fix/BCI-2606-document-metrics-renaming branch from 0a92cf1 to ca2ec35 Compare January 19, 2024 14:17
@dhaidashenko dhaidashenko requested review from a team as code owners January 19, 2024 14:17
@dhaidashenko dhaidashenko changed the base branch from develop to release/2.8.0 January 19, 2024 14:17
@dhaidashenko dhaidashenko deleted the fix/BCI-2606-document-metrics-renaming branch January 19, 2024 14:18
@dhaidashenko dhaidashenko restored the fix/BCI-2606-document-metrics-renaming branch January 19, 2024 14:19
@snehaagni snehaagni deleted the fix/BCI-2606-document-metrics-renaming branch January 19, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants