-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make missing fields return invalid type instead of sometimes defaulting and other times not. #11826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolag
force-pushed
the
rtinianov_notopt
branch
from
January 19, 2024 18:41
42c6d3f
to
f8e19b3
Compare
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
nolag
force-pushed
the
rtinianov_notopt
branch
from
January 19, 2024 20:03
9bd4f6a
to
f8e19b3
Compare
nolag
force-pushed
the
rtinianov_notopt
branch
from
January 22, 2024 20:04
f8e19b3
to
95a61ba
Compare
nolag
force-pushed
the
rtinianov_notopt
branch
from
January 22, 2024 20:23
95a61ba
to
cb77d18
Compare
nolag
force-pushed
the
rtinianov_notopt
branch
from
January 23, 2024 00:45
cb77d18
to
2a69586
Compare
nolag
force-pushed
the
rtinianov_notopt
branch
from
January 23, 2024 01:57
2a69586
to
fb9f821
Compare
nolag
requested review from
jmank88,
krehermann,
a team,
chainchad,
javuto,
jkongie,
samsondav,
RensR,
bolekk,
justinkaseman,
KuphJr,
sdrug,
martin-cll and
connorwstein
as code owners
January 23, 2024 01:57
nolag
force-pushed
the
rtinianov_notopt
branch
from
January 23, 2024 02:09
fb9f821
to
1f63afd
Compare
jmank88
reviewed
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nolag
force-pushed
the
rtinianov_notopt
branch
from
January 23, 2024 14:27
1f63afd
to
695109d
Compare
…ng and other times not.
nolag
force-pushed
the
rtinianov_notopt
branch
from
January 23, 2024 14:27
695109d
to
1ec4590
Compare
jmank88
approved these changes
Jan 23, 2024
SonarQube Quality Gate |
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.