(feat): Add ability for Functions ToS migrations #11827
Conversation
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
Go solidity wrappers are out-of-date, regenerate them via the |
| constructor(TermsOfServiceAllowListConfig memory config) ConfirmedOwner(msg.sender) { | ||
| constructor( | ||
| TermsOfServiceAllowListConfig memory config, | ||
| address[] memory initialAllowedSenders, |
There was a problem hiding this comment.
Are we going to run into gas issues if the allowlist gets too large?
Also, what will the EngOps process be for this contract upgrade?
There was a problem hiding this comment.
I wonder if a "admin add" feature is a better option where the contract owner can manually add people to the allowlist.
There was a problem hiding this comment.
Should be able to just automate all of the process with tooling.
As for size, I was thinking that too. Let me add a unit test to see how many we can reasonably add. I agree that another method will be needed if we need to batch add people.
There was a problem hiding this comment.
Repeating from slack thread:
Tested up to 500k addresses via a unit test.
Leaving the unit test out because it does slow down the test suite by 20-30 seconds.
|
Go solidity wrappers are out-of-date, regenerate them via the |
agparadiso
force-pushed
the
feature/FUN-877_persist_data_fetched_from_contracts_allowlist
branch
from
09e890b to
624c220
Compare
agparadiso
force-pushed
the
feature/FUN-877_persist_data_fetched_from_contracts_allowlist
branch
7 times, most recently
from
4ee343a to
e338964
Compare
justinkaseman
force-pushed
the
FUN-1206
branch
from
19e29d9 to
3517a63
Compare
|
Go solidity wrappers are out-of-date, regenerate them via the |
justinkaseman
force-pushed
the
FUN-1206
branch
from
3517a63 to
a4b1fb1
Compare
justinkaseman
force-pushed
the
FUN-1206
branch
from
a4b1fb1 to
3b9631e
Compare
justinkaseman
requested review from
a team
and removed request for
jmank88 and
samsondav
justinkaseman
force-pushed
the
FUN-1206
branch
from
3b9631e to
d016f15
Compare
justinkaseman
force-pushed
the
FUN-1206
branch
from
19cff85 to
d5227c6
Compare
|
* develop: KS-35: EVM Encoder compatible with consensus capability (#12025) (feat): Add ability for Functions ToS migrations (#11827) FUN-1247 (refactor): Move Functions Coordinator duplicate request ID check earlier (#12018) Add plugins build back into CI (#12054) chore: github action version bumps (#12023) Bump libocr to fe2ba71b2f0a0b66f95256426fb6b8e2957e1af4 (#12049) Pin to latest version chainlink-common (#12053) Node API capabilities registry (#12046)
No description provided.