Cleaning up CODEOWNERS #11868
Merged
Cleaning up CODEOWNERS #11868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
patrickhuie19
force-pushed
the
BCF-2913-CODEOWNERS-cleanup
branch
from
14e74d6 to
ace4a12
Compare
chainchad
previously requested changes
Jan 30, 2024
patrickhuie19
force-pushed
the
BCF-2913-CODEOWNERS-cleanup
branch
from
bce3f4b to
e4ef794
Compare
patrickhuie19
commented
Feb 5, 2024
| /contracts/**/*vrf* @smartcontractkit/vrf-team | ||
| /contracts/**/*l2ep* @simsonraj | ||
| /contracts/**/*operatorforwarder* @essamhassan | ||
|
|
||
| /contracts/src/v0.8/automation @smartcontractkit/keepers | ||
| /contracts/src/v0.8/functions @smartcontractkit/functions | ||
| # TODO: interfaces folder, folder should be removed and files moved to the correct folders |
There was a problem hiding this comment.
These TODOs are still valid. We should capture the effort in a ticket and link here if possible. (cc @RensR + @chris-de-leon-cll for context)
patrickhuie19
commented
Feb 5, 2024
patrickhuie19
commented
Feb 5, 2024
| @@ -2,37 +2,28 @@ | |||
| # 1. Per Github docs: "Order is important; the last matching pattern takes the most precedence." | |||
There was a problem hiding this comment.
The errors in this file result because mercury-team, devrel, and FMS don't have write access. That should be updated.
jmank88
reviewed
Feb 5, 2024
samsondav
reviewed
Feb 5, 2024
jmank88
reviewed
Feb 5, 2024
jmank88
reviewed
Feb 5, 2024
jmank88
reviewed
Feb 5, 2024
Co-authored-by: chainchad <[email protected]>
Co-authored-by: Jordan Krage <[email protected]>
Co-authored-by: Jordan Krage <[email protected]>
Co-authored-by: Jordan Krage <[email protected]>
Co-authored-by: Jordan Krage <[email protected]>
patrickhuie19
force-pushed
the
BCF-2913-CODEOWNERS-cleanup
branch
from
de141d3 to
0fbd2a6
Compare
|
SonarQube Quality Gate
|
jmank88
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal: