-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade v2.2 and related contracts to v0.8.19 and generate wrappers #11888
Conversation
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
@@ -1,5 +1,5 @@ | |||
// SPDX-License-Identifier: BUSL-1.1 | |||
pragma solidity 0.8.16; | |||
pragma solidity >=0.8.16 <=0.8.19; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove the upper bound? I think this would suffice...
pragma solidity ^0.8.16;
@@ -1,5 +1,5 @@ | |||
// SPDX-License-Identifier: MIT | |||
pragma solidity 0.8.16; | |||
pragma solidity >=0.8.16 <=0.8.19; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment
Updated the rebased the PR. |
you need to update the foundry test version too. for the registry 2.2 |
Yes, just updated. I think they are recently added so I missed them yesterday. |
@@ -79,7 +79,7 @@ describe('KeeperRegistry2_1 - Frozen [ @skip-coverage ]', () => { | |||
) | |||
assert.equal( | |||
ethers.utils.id(AutomationForwarderLogicFactory.bytecode), | |||
'0x195e2d7ecc26c75206820a5d3bd16e3a0214dc9764cc335f5d2c457cda90fe84', | |||
'0x6b89065111e9236407329fae3d68b33c311b7d3b6c2ae3dd15c1691a28b1aca7', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RyanRHall @FelixFan1992 I updated this hex in this v21 test case, this changed after I bumped up the AutomationForwarderLogicFactory solidity version.
SonarQube Quality Gate 0 Bugs No Coverage information |
Upgrade the Registry, Registrar, and unlock any necessary dependancies (ex the forwarder and forwarder logic will probably need to be unlocked)
Also re-generate the go wrappers
contracts/src/v0.8/automation/AutomationForwarder.sol and Chainable.sol are shared btw v2.1 and v2.2 hence using a version range.
Test plan:
pnpm hardhat test test/v0.8/automation/AutomationRegistry2_2.test.ts
all tests passed.pnpm ts-node ./scripts/generate-automation-master-interface.ts
nothing changed.go generate core/gethwrappers/go_generate.go
some wrappers regenerated./contracts/src/v0.8/automation/dev/test
,forge test
, all compile.