-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor EVM ORMs #11899
Refactor EVM ORMs #11899
Conversation
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
I see that you haven't updated any README files. Would it make sense to do so? |
…contractkit/chainlink into BCI-2644-refactor-evm-orms
7004e3f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge PR so just skimmed it, but change seems reasonable. As long as we are preserving slow query logging, default timeouts and metrics this seems fine.
Are we preserving the cases where a long timeout is needed?
I believe there happen to be none in this PR, but the following PRs can make use of |
Quality Gate passedIssues Measures |
* Initial commit * Refactor headtracker orm * Remove unused loggers * Remove comments * Add timeout * Refactor log_poller ORM * Refactor logpoller ORM * Fix logpoller tests * Update logpoller orm * Use EventSig * update logpoller orm * Update orm.go * Update logpoller_wrapper_test.go * Update log_poller_test.go * Remove query * Remove ORM timeouts * Add context * Use testutils for context * Use testutils context * Use testutils context * Use ctx * Refactor forwarder ORM * Generate tidy * Fix logpoller mocks * Remove pg dependency * Fix mock calls * Fix mock calls * Fix mock calls * Use request context * Update context * Update contexts * Fix mock call args * Unexport orm * Fix arg name * update logpoller * unexport orm * Use query * fix tests * fix imports * Use pkgerrors * Use registry ctx * Use context * Use ctx * Use ctx * Update orm.go * Use context * Use context * Use context * Propagate context * Propagate context * Update listener_test.go * Fix context * Export DbORM struct * Update orm.go * Pass context * Pass context * Update orm.go * Use testcontext * Initialize context * Update context * Propagate context * core/services/chainlink: start using sqlutil.DB instead of pg.Q (#12386) * Check bind errors * Add close timeout * Add changeset --------- Co-authored-by: Jordan Krage <[email protected]>
Refactor Headtracker, Forwarder, and Logpoller ORMs to remove dependency on core/services/pg and Q type.