Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EVM ORMs #11899

Merged
merged 123 commits into from
Mar 14, 2024
Merged

Refactor EVM ORMs #11899

merged 123 commits into from
Mar 14, 2024

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Jan 25, 2024

Refactor Headtracker, Forwarder, and Logpoller ORMs to remove dependency on core/services/pg and Q type.

Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@DylanTinianov DylanTinianov changed the title Refactor EVM ORMs Refactor Headtracker ORM Jan 25, 2024
@DylanTinianov DylanTinianov changed the title Refactor Headtracker ORM Refactor EVM Headtracker ORM Jan 25, 2024
@DylanTinianov DylanTinianov changed the title Refactor EVM Headtracker ORM Refactor EVM ORMs Feb 8, 2024
Copy link
Collaborator

@samsondav samsondav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge PR so just skimmed it, but change seems reasonable. As long as we are preserving slow query logging, default timeouts and metrics this seems fine.

Are we preserving the cases where a long timeout is needed?

@jmank88
Copy link
Contributor

jmank88 commented Mar 14, 2024

Are we preserving the cases where a long timeout is needed?

I believe there happen to be none in this PR, but the following PRs can make use of WithoutDefaultTimeout to skip the default and include their own.

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Mar 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 14, 2024
@jmank88 jmank88 added this pull request to the merge queue Mar 14, 2024
Merged via the queue into develop with commit 67560b9 Mar 14, 2024
98 checks passed
@jmank88 jmank88 deleted the BCI-2644-refactor-evm-orms branch March 14, 2024 16:42
kidambisrinivas pushed a commit that referenced this pull request Mar 27, 2024
* Initial commit

* Refactor headtracker orm

* Remove unused loggers

* Remove comments

* Add timeout

* Refactor log_poller ORM

* Refactor logpoller ORM

* Fix logpoller tests

* Update logpoller orm

* Use EventSig

* update logpoller orm

* Update orm.go

* Update logpoller_wrapper_test.go

* Update log_poller_test.go

* Remove query

* Remove ORM timeouts

* Add context

* Use testutils for context

* Use testutils context

* Use testutils context

* Use ctx

* Refactor forwarder ORM

* Generate tidy

* Fix logpoller mocks

* Remove pg dependency

* Fix mock calls

* Fix mock calls

* Fix mock calls

* Use request context

* Update context

* Update contexts

* Fix mock call args

* Unexport orm

* Fix arg name

* update logpoller

* unexport orm

* Use query

* fix tests

* fix imports

* Use pkgerrors

* Use registry ctx

* Use context

* Use ctx

* Use ctx

* Update orm.go

* Use context

* Use context

* Use context

* Propagate context

* Propagate context

* Update listener_test.go

* Fix context

* Export DbORM struct

* Update orm.go

* Pass context

* Pass context

* Update orm.go

* Use testcontext

* Initialize context

* Update context

* Propagate context

* core/services/chainlink: start using sqlutil.DB instead of pg.Q (#12386)

* Check bind errors

* Add close timeout

* Add changeset

---------

Co-authored-by: Jordan Krage <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants