[Gateway] Better logging around node connectivity #11929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bolekk
commented
Feb 5, 2024
bolekk
commented
- Rename "heartbeat" -> "keepalive" to avoid confusion with other types of heartbeats.
- Log node name alongside failed pings for easier debugging.
|
I see that you haven't updated any README files. Would it make sense to do so? |
KuphJr
previously approved these changes
Feb 5, 2024
bolekk
force-pushed
the
chore/pingpong_logs
branch
from
e99ca75 to
fc1fd56
Compare
bolekk
force-pushed
the
chore/pingpong_logs
branch
from
fc1fd56 to
84e9b52
Compare
1. Rename "heartbeat" -> "keepalive" to avoid confusion with other types of heartbeats. 2. Log node name alongside failed pings for easier debugging.
bolekk
force-pushed
the
chore/pingpong_logs
branch
from
84e9b52 to
3c78b78
Compare
|
SonarQube Quality Gate
|
justinkaseman
approved these changes
Feb 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.