core/chains/evm/assets: FuzzWei skip large exponents #11948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
jmank88
commented
Feb 6, 2024
| func tryParseExp(v string) int64 { | ||
| i := strings.IndexAny(v, "Ee") | ||
| if i == -1 { | ||
| return -1 |
There was a problem hiding this comment.
Now I am thinking we'll have to bound negative exponents too 🤔
|
SonarQube Quality Gate
|
vyzaldysanchez
approved these changes
Feb 6, 2024
smickovskid
pushed a commit
that referenced
this pull request
Feb 7, 2024
aalu1418
added a commit
that referenced
this pull request
Feb 7, 2024
* Minor changes (#11943) * core/chains/evm/assets: FuzzWei skip large exponents (#11948) * core/chains/evm/assets: fix FuzzWei range detection (#11950) * Adding ocr2 to configs * Solana bumps * Reverting mistake rebase changes * Bump go deps * Added ocr2 conf * fix typo + gomodtidy * bump solana * bump solana: fix test compilation * fix: setup CI to pull CL image version for toml * bump solana to merged commit --------- Co-authored-by: aalu1418 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
* Implement LLO relayer interface * Fix case coverage for loops * Point chain repos to latest * generate mocks * Adding ocr2 to configs + fix solana e2e tests (#11952) * Minor changes (#11943) * core/chains/evm/assets: FuzzWei skip large exponents (#11948) * core/chains/evm/assets: fix FuzzWei range detection (#11950) * Adding ocr2 to configs * Solana bumps * Reverting mistake rebase changes * Bump go deps * Added ocr2 conf * fix typo + gomodtidy * bump solana * bump solana: fix test compilation * fix: setup CI to pull CL image version for toml * bump solana to merged commit --------- Co-authored-by: aalu1418 <[email protected]> * Add MockRelayer function * Make sonarqube run * Exclude integration tests from sonarqube duplicate coverage * Properly format sonarqube file --------- Co-authored-by: Damjan Smickovski <[email protected]> Co-authored-by: aalu1418 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vyzaldysanchez observed a randomly generated case of
0e488888880timing out. It seems this is simply too large of a number, and our existing bounds on 1000 characters in the string does not sufficiently limit cases with exponent notation. This PR introduces a small check to limit based on exponent size as well, a few orders of magnitude below the observed case.