Prep work for LLO #11955
Merged
Prep work for LLO #11955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
samsondav
commented
Feb 7, 2024
samsondav
commented
- Includes minor changes/cleanups for unrelated code
|
I see that you haven't updated any README files. Would it make sense to do so? |
samsondav
force-pushed
the
MERC-3487-benchmark-test-mercury-parallel-compositions
branch
from
256b8ea to
46b703d
Compare
samsondav
force-pushed
the
MERC-3487-benchmark-test-mercury-parallel-compositions
branch
from
46b703d to
5dee91e
Compare
- Includes minor changes/cleanups for unrelated code
samsondav
force-pushed
the
MERC-3487-benchmark-test-mercury-parallel-compositions
branch
from
5dee91e to
79df493
Compare
|
SonarQube Quality Gate
|
akuzni2
approved these changes
Feb 9, 2024
jmank88
reviewed
Feb 9, 2024
| @@ -66,9 +66,13 @@ func overrides(c *chainlink.Config, s *chainlink.Secrets) { | |||
| c.WebServer.TLS.ListenIP = &testIP | |||
|
|
|||
| chainID := big.NewI(evmclient.NullClientChainID) | |||
|
|
|||
| chainCfg := evmcfg.Defaults(chainID) | |||
| chainCfg.LogPollInterval = commonconfig.MustNewDuration(1 * time.Second) // speed it up from the standard 15s for tests | |||
There was a problem hiding this comment.
Seems reasonable, but how does it affect other tests? Presumably nothing broke - but does this also represent an opportunity to speed up any tests by tuning related values?
jmank88
approved these changes
Feb 9, 2024
samsondav
deleted the
MERC-3487-benchmark-test-mercury-parallel-compositions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.