Allow for custom config poller onchain codec (LLO support) #11957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
samsondav
force-pushed
the
MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec
branch
from
a7977e8 to
1c73a2d
Compare
samsondav
force-pushed
the
MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec
branch
from
90edd93 to
5f737d5
Compare
samsondav
force-pushed
the
MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec
branch
from
5f737d5 to
3e0b260
Compare
samsondav
force-pushed
the
MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec
branch
from
3e0b260 to
43ce912
Compare
samsondav
force-pushed
the
MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec
branch
from
b316932 to
ffe9bf3
Compare
jmank88
reviewed
Feb 13, 2024
jmank88
reviewed
Feb 13, 2024
krehermann
reviewed
Feb 13, 2024
krehermann
reviewed
Feb 13, 2024
krehermann
reviewed
Feb 13, 2024
krehermann
reviewed
Feb 13, 2024
krehermann
reviewed
Feb 13, 2024
| } | ||
|
|
||
| func configPollerFilterName(addr common.Address) string { | ||
| return logpoller.FilterName("OCR2ConfigPoller", addr.String()) | ||
| } | ||
|
|
||
| func NewConfigPoller(lggr logger.Logger, client client.Client, destChainPoller logpoller.LogPoller, aggregatorContractAddr common.Address, configStoreAddr *common.Address) (evmRelayTypes.ConfigPoller, error) { |
There was a problem hiding this comment.
this signature is getting unwieldy. since you are making a break signature change anyway, i would make a config struct to house much of this stuff. maybe ~ NewConfigPoller(lggr, cfg)
samsondav
force-pushed
the
MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec
branch
from
9e81dd6 to
b1e3364
Compare
samsondav
force-pushed
the
MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec
branch
from
b1e3364 to
cc70a2f
Compare
jmank88
previously approved these changes
Feb 13, 2024
krehermann
previously approved these changes
Feb 13, 2024
jmank88
previously approved these changes
Feb 13, 2024
samsondav
force-pushed
the
MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec
branch
from
9875d44 to
de9f941
Compare
jmank88
approved these changes
Feb 13, 2024
|
samsondav
deleted the
MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec
branch
momentmaker
added a commit
that referenced
this pull request
Feb 15, 2024
* develop: (74 commits) VRF zero confirmation delay (#11947) add toml configs to paths that can cause e2e tests to run in ci (#12001) bump golang.org/x/... (#12042) [chore] Replace clock with specialized lib (#12031) Update style guide (#12041) plugins/cmd/chainlink-mercury: (re)move to chainlink-data-streams repo (#11994) bump go-plugin (#12033) Adds timeout on fuzz script execution (#12024) Add bytes type to abi_type (#12029) AUTO-8804: create chain specific modules for l1 gas calculations (#11896) VRF-878 Gas Optimization V2 Plus (#11982) Improving deletes performance by limiting number of records to scan (#12007) core/web: improve health CLI readabilty (#12021) Handle a 0 exit code from the remote runner instead of always failing (#12015) Add a simple Codec test (#12006) Allow for custom config poller onchain codec (LLO support) (#11957) Update Sonar properties (#11986) golangci-lint: revive: add early-return; fix issues (#12017) Implement NewPluginProvider (EVM) (#11995) Fix lock file version and minor NPM bumps (#11980) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't make much sense unless you view in the context of enabling this: #10810