Auto 8888 properly account for l 1 gas overhead for l 2 chains op scroll arb

[RyanRHall]

Changes in this PR

• Remove Gas overhead capping and prepayment check in transmit

  • The gas overhead capping was there to prevent edge cases when upkeep didn't have enough funds during accounting. Having this added many edge cases when accounting for chain specific differences and calculating the exact overhead cap, so we are removing it. In most cases the upkeep is expected to have enough funds since we also have the gasMultiplier applied during checkUpkeep, however in rare edge cases, we just zero out the upkeep balance if it doesn't have enough funds
  • Having this logic also allows us to remove the prepayment check in transmit. Now we just rely on payment check during checkUpkeep, if report comes on chain upkeep can have less balance then we zero out the balance. The balance could have been different from checkUpkeep time due to L1 fluctuations. (fastGasFeed, linkNative are the same as check time, so they don't fluctuate, upkeep balance can't be withdrawn without cancellation). Since we already put calldata on L1, it's just better to perform the upkeep and charge it for what it has.
  • Removing this also simplifies maxLinkPayment Function which is now only called during checkUpkeep simulation

• Refine gas calculation during transmit to be simpler and more accurate

  • Remove accounting per signer overhead since accounting is independent of 'f' so it was redundant
  • instead of accounting for report.length16, use msg.data16 for the whole calldata

• Refine L1 fee distribution in batch

  • Instead of equal division, divide them according to performData weight (+overhead) for more accurate charging

• Refine maxLinkPayment gas overhead calculation

  • Add variables for calldata bytes overhead in addition to performdata
  • Account for chain module overheads, fetched from the module itself and account for this in maxLinkPayment

• Refine ChainModules for arb, op and scroll to be more accurate

• Small refactor in transmit path to create TransmitVars to circumvent stack too deep errors

• Small cleanup to remove setChainSpecificModule which is redundant as the module can be set in setConfig

[github-actions]

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

[github-actions]

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

[github-actions]

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

[github-actions]

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube