-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add checkErrorHandler #12014
Closed
Closed
add checkErrorHandler #12014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: bump docker/login action to 3.0.0 * chore: bump docker/metadata-action to 5.5.0 * chore: bump actions/upload-artifact to 3.1.3 * chore: bump actions/setup-go to 5.0.0 * chore: bump docker/setup-qemu-action to 3.0.0 * chore: bump goreleaser/goreleaser-action to 5.0.0 * chore: bump goto-bus-stop/setup-zig to 2.2.0 * chore: bump actions/download-artifact to 3.0.2 * chore: bump github/codeql to 2.16.1
…11805) * Added bump legacy gas implementation to the Suggested Price Estimator * Updated logic to add a buffer on top of the new suggested gas price when bumping * Addressed feedback * Added comments to the SuggestedPriceEstimator BumpLegacyGas method * Removed BumpPercent and BumpMin configs from arbgas cmd
* take pruning logic out of create_transaction logic * change prune queue function signature to return array of ids rather than count * refactor txmgr a little * change order of pruning and creating transaction * Apply suggestions from code review Co-authored-by: amit-momin <[email protected]> * address comments * fix tests * address comments * address comments * add pruneQueueAndCreateLock --------- Co-authored-by: amit-momin <[email protected]> Co-authored-by: Prashant Yadav <[email protected]>
* Added L1 gas cost estimation feature to L1 gas oracle for Arbitrum, Optimism, and Scroll * Updated implementation to use ABIs to pack payloads * Fixed linting * Addressed feedback * Fixed linting * Fixed linting
* Add Polygon zkEVM config * Add more config * Adjust config * Test config * Debug without from block * Update config * Add on demand option * Update config * increased min PriceMin & resend threshold to avoid gas bumping & fast transactions * Update toml config * Update toml config * Update toml config * Update toml config mainnet * Update toml config mainnet * Update toml config mainnet * Update toml config mainnet * Adjust config * Patch go version * Patch go version * Fine tune config * Fine tune config * updated Price Min * Revert go version change * Update testing branch * Revert go mod * Update config docs --------- Co-authored-by: simsonraj <[email protected]>
* Use uint64 for stream IDs * Reduce size of index
* make billing more flexible in VRF 2.5 - percentage based billing - flat fee denominated in native * fix linting issues * address comments and fix failing tests * run goimports * fix linting issue
* start working on capability.go * Combine CapabilityInfoProvider and CapabilityInfo; Add validation tests * Validate the capability type when adding it * Replace Stringer with string for simplicity * Remove SynchronousCapability interface in favour of using async * Add comments to public functions and variables * Add ExecuteSync method. Provide more info on the Executable interface. * Add a Test_ExecuteSyncReturnSingleValue * Review comments * Add CapabilityResponse struct for Execute channel * Undo chainlink-common change * Add reasoning behind code * Add missing tests * Create CallbackExecutable. Trim interfaces. * Start on an example on demand capability * Add different capability types to registry * Complete example trigger * Fix race * Add TODOs for defaultExecuteTimeout/idMaxLength * Move capability info to a var; add must handle * Remove tmockCapability * Udpate broken comment * Add some tests * RegisterUnregisterWorkflow interface * cmock => mock * Create a const for test var * Use testutils.Context(t) * Do not unwrap single value from a list * Channel naming * MustCapabilityInfo => MustNewCapabilityInfo * Tidy more * examples => triggers && downstream --------- Co-authored-by: Cedric Cordenier <[email protected]>
* Restore restored functionality tests * Update gas snapshot
* Restore restored functionality tests * Update gas snapshot * Update compiler version * update wrappers * Added snapshot
* temp CRIB workshop * tested script + build/deploy separation * check images in ECR, fail if no image built * another try with ecr * force login to registry --------- Co-authored-by: skudasov <[email protected]>
* Add devspace helm values to create ingress in K8s * fix devspace ingress defs * Fix geth port * Fix print out of URLs --------- Co-authored-by: skudasov <[email protected]>
* Re-add back network policies. From commit: dc9a073 * Create network policies conditionally
1. Rename "heartbeat" -> "keepalive" to avoid confusion with other types of heartbeats. 2. Log node name alongside failed pings for easier debugging.
… remove some whitespaces (#11941)
* WIP: cleanup * further cleanup * Update CODEOWNERS Co-authored-by: chainchad <[email protected]> * further cleanup * further cleanup * Update CODEOWNERS Co-authored-by: Jordan Krage <[email protected]> * further cleanup * further cleanup * Update CODEOWNERS Co-authored-by: Jordan Krage <[email protected]> * Update CODEOWNERS Co-authored-by: Jordan Krage <[email protected]> * Update CODEOWNERS Co-authored-by: Jordan Krage <[email protected]> --------- Co-authored-by: chainchad <[email protected]> Co-authored-by: Jordan Krage <[email protected]>
* VRF-329: add BHS CTF test * VRF-329: add BHS CTF test - VRF v2 and V2Plus; Refactoring to make it a bit more DRY * VRF-329: small refactoring * VRF-329: fixing lint issues * VRF-329: fixing lint issues * VRF-329: fixing lint issues * VRF-329: fixing lint issues * VRF-329: fixing lint issues * VRF-329: trying to remove flakiness
* Remove unused method * Fix test failing * Fix tests * Cleanup and lint fix * Restore t.Parallel * Do not ignore NewNodePayloadResolver error * Return empty ChainsPayload if no chains are configured
* Update default OCR2.Automation.GasLimit to 5.4M * make docs * fix remaining places * update more files
shileiwill
requested review from
infiloop2 and
amirylm
and removed request for
a team
February 14, 2024 22:48
shileiwill
changed the base branch from
develop
to
auto-9004-stream-err-handler
February 14, 2024 22:49
shileiwill
requested review from
jmank88,
krehermann,
a team,
chainchad,
javuto,
jkongie,
samsondav,
austinborn,
Fletch153,
bolekk,
justinkaseman,
KuphJr,
sdrug,
martin-cll,
connorwstein,
prashantkumar1982,
RyanRHall and
reductionista
as code owners
February 14, 2024 22:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checkErrorHandler in contracts/src/v0.8/automation/interfaces/StreamsLookupCompatibleInterface.sol
All new contracts can add this checkErrorHandler function so they can have the streams lookup errors.