[KS-33] Add loop binary #12050
Merged
[KS-33] Add loop binary #12050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
had a problem deploying
to
sdlc
GitHub Actions
Failure
|
I see that you haven't updated any README files. Would it make sense to do so? |
bolekk
reviewed
Feb 16, 2024
| s := loop.MustNewStartedServer(loggerName) | ||
| defer s.Stop() | ||
|
|
||
| factory := func(c *values.Map) (consensustypes.Encoder, error) { |
There was a problem hiding this comment.
Current workflow spec proposal lists encoder name as a top level param separate from encoder config. If we want to keep it that way then let's add a separate name param here as well.
bolekk
reviewed
Feb 16, 2024
cedric-cordenier
force-pushed
the
add-loop-binary
branch
from
7184b40 to
f2253b4
Compare
cedric-cordenier
temporarily deployed
to
sdlc
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
sdlc
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
sdlc
GitHub Actions
Inactive
cedric-cordenier
force-pushed
the
add-loop-binary
branch
from
fb8edfd to
9ec3e83
Compare
cedric-cordenier
temporarily deployed
to
sdlc
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
sdlc
GitHub Actions
Inactive
cedric-cordenier
had a problem deploying
to
sdlc
GitHub Actions
Failure
cedric-cordenier
temporarily deployed
to
sdlc
GitHub Actions
Inactive
george-dorin
approved these changes
Feb 16, 2024
vyzaldysanchez
approved these changes
Feb 16, 2024
|
jmank88
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.