Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FUN-1234] refactor logpoller_wrapper by injecting a coordinator dep #12066

Merged
merged 6 commits into from
Feb 19, 2024
Merged

[FUN-1234] refactor logpoller_wrapper by injecting a coordinator dep #12066

merged 6 commits into from
Feb 19, 2024

Conversation

agparadiso
Copy link
Contributor

@agparadiso agparadiso commented Feb 16, 2024 •
edited
Loading

Description

small refactor splitting coordinator behaviour in V1 and V2 and injecting it on the logpoller

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@agparadiso agparadiso force-pushed the FUN-1234_dep_injection branch from f67cada to f25861a Compare February 19, 2024 14:18
@agparadiso agparadiso force-pushed the FUN-1234_dep_injection branch from f25861a to fdca1f6 Compare February 19, 2024 15:00
@agparadiso agparadiso force-pushed the FUN-1234_dep_injection branch from fdca1f6 to 8930b24 Compare February 19, 2024 16:38
@agparadiso agparadiso force-pushed the FUN-1234_dep_injection branch from 8930b24 to ea0ec6d Compare February 19, 2024 16:40
@justinkaseman justinkaseman force-pushed the FUN-1234 branch 2 times, most recently from 6c85940 to 09df392 Compare February 19, 2024 19:34
@agparadiso agparadiso force-pushed the FUN-1234_dep_injection branch from 36496b0 to c9f4114 Compare February 19, 2024 22:33
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@justinkaseman justinkaseman marked this pull request as ready for review February 19, 2024 23:25
@justinkaseman justinkaseman requested a review from a team as a code owner February 19, 2024 23:25
@justinkaseman justinkaseman self-requested a review February 19, 2024 23:25
justinkaseman
justinkaseman approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@justinkaseman justinkaseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@justinkaseman justinkaseman merged commit 2adfc1b into FUN-1234 Feb 19, 2024
117 checks passed
@justinkaseman justinkaseman deleted the FUN-1234_dep_injection branch February 19, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkaseman justinkaseman justinkaseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agparadiso @justinkaseman