Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll L2EP Fixes #12069

Closed
wants to merge 11 commits into from
Closed

Scroll L2EP Fixes #12069

wants to merge 11 commits into from

Conversation

chris-de-leon-cll
Copy link
Contributor

@chris-de-leon-cll chris-de-leon-cll commented Feb 16, 2024 •
edited
Loading

Adds:

  1. Gas estimate calculation to scroll validator
  2. AdressAliasHelper contract for scroll since it is not included in the scroll-tech npm package
  3. Aliased address auth checking to scroll sequencer uptime feed updateStatus function
  4. Updated Foundry and Hardhat tests

@chris-de-leon-cll
adds gas estimate calculation to scroll validator and updates scroll …
7b671f7 
…sequencer uptime feed update status function auth check to use aliased address
@chris-de-leon-cll chris-de-leon-cll self-assigned this Feb 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@chris-de-leon-cll chris-de-leon-cll changed the title Scroll Fixes Scroll L2EP Fixes Feb 16, 2024
@mohamed-mehany
Revert "resolving merge conflicts"
84050ce 
This reverts commit dd24c6c, reversing
changes made to da02459.
@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamed-mehany mohamed-mehany Awaiting requested review from mohamed-mehany

Assignees

@chris-de-leon-cll chris-de-leon-cll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-de-leon-cll @mohamed-mehany