chore: export ABIs in the compile step #12083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
RensR
previously approved these changes
Feb 20, 2024
scheibinger
force-pushed
the
re-2285/fix-abi
branch
from
fef91b7 to
b0973e6
Compare
By default ABIs where not exported in the compile step. Updated the dir path to fetch ABIs from the target location used by prepublish script.
scheibinger
force-pushed
the
re-2285/fix-abi
branch
from
b0973e6 to
5418875
Compare
RensR
approved these changes
Feb 21, 2024
erikburt
approved these changes
Feb 21, 2024
chainchad
approved these changes
Feb 21, 2024
|
scheibinger
added a commit
that referenced
this pull request
Feb 22, 2024
By default ABIs where not exported in the compile step. Updated the dir path to fetch ABIs from the target location used by prepublish script. Co-authored-by: chainchad <[email protected]>
scheibinger
added a commit
that referenced
this pull request
Feb 22, 2024
By default ABIs where not exported in the compile step. Updated the dir path to fetch ABIs from the target location used by prepublish script. Co-authored-by: chainchad <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
* Update CHANGELOG and package version for contracts * Set version to initial beta * (chore): Additional Functions changelog entries for v1.0.0 contracts release (#11794) * chore: export ABIs in the compile step (#12083) By default ABIs where not exported in the compile step. Updated the dir path to fetch ABIs from the target location used by prepublish script. Co-authored-by: chainchad <[email protected]> * Bump contracts version Signed-off-by: Sneha Agnihotri <[email protected]> * Update changelog Signed-off-by: Sneha Agnihotri <[email protected]> * Prep for final @chainlink/contracts 1.0.0 release --------- Signed-off-by: Sneha Agnihotri <[email protected]> Co-authored-by: chainchad <[email protected]> Co-authored-by: Justin Kaseman <[email protected]> Co-authored-by: Radek Scheibinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the issue with ABIs not included in the published chainlink-contracts npm package for version 1.0.0
Testing
I've tested this by running following commands inside the
contractsdir:git clean -dfxpnpm installpnpm prepublishOnly(that includes the compile step)pnpm pack --pack-destinationAfter that sequence exported ABIs were included in the release tarball