Add native payment to RandomWordsFulfilled event #12085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
Do all the integration tests pass? |
vreff
previously approved these changes
Feb 19, 2024
|
vreff
approved these changes
Feb 19, 2024
jinhoonbang
approved these changes
Feb 19, 2024
jinhoonbang
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Add native payment to RandomWordsFulfilled event * Minor change --------- Co-authored-by: Sri Kidambi <[email protected]>
jinhoonbang
added a commit
that referenced
this pull request
Feb 20, 2024
* VRF V2.5 gas optimisations (#11932) * VRF V2.5 gas optimisations * Minor changes * Removed changes in SubscriptionAPI.sol due to no actual gain in hot paths * Minor changes * VRF-878 Gas Optimization V2 Plus (#11982) * Optimize deregisterProvingKey * Optimize fulfillRandomWords * Optimize deregisterMigratableCoordinator * Optimize _isTargetRegistered * Optimize pendingRequestExists * Optimize _deleteSubscription * Optimize getActiveSubscriptionIds * Optimize requestRandomWords * Replace post-increment with pre-increment * Optimize _getFeedData * Optimize ownerCancelSubscription * Optimize getSubscription * Optimize createSubscription * Optimize requestSubscriptionOwnerTransfer * Optimize acceptSubscriptionOwnerTransfer * Optimize addConsumer * Update geth wrappers * Remove proving keys length check in pendingRequestExists * Add native payment to RandomWordsFulfilled event (#12085) * Add native payment to RandomWordsFulfilled event * Minor change --------- Co-authored-by: Sri Kidambi <[email protected]> --------- Co-authored-by: Sri Kidambi <[email protected]> Co-authored-by: Lee Yik Jiun <[email protected]> Co-authored-by: Lee Yik Jiun <[email protected]>
kidambisrinivas
added a commit
that referenced
this pull request
Mar 18, 2024
* Add native payment to RandomWordsFulfilled event * Minor change --------- Co-authored-by: Sri Kidambi <[email protected]>
kidambisrinivas
added a commit
that referenced
this pull request
Mar 18, 2024
* Add native payment to RandomWordsFulfilled event * Minor change --------- Co-authored-by: Sri Kidambi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
nativePaymenttoRandomWordsFulfilledevent so that the payment information is self contained within the event itself, instead of deriving from the request event.Gas changes:
Note that the above numbers include gas cost from recoding logs and abi decode in the test as well.
| fulfillRandomWords | 26378 | [-96665-]{+96915+} | [-101093-]{+101406+} | [-127444-]{+127757+} | 5 |Increases gas cost by around 313.