Call check error handler within mercury #12088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
…r, fix some minor comments (typo and test)
shileiwill
reviewed
Feb 20, 2024
There was a problem hiding this comment.
The overall structure looks great to me. I left some comments and also addressed some of my own comments in this commit. Let me know your thoughts.
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/encoding/interface.go
Show resolved
Hide resolved
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/mercury/mercury.go
Outdated
Show resolved
Hide resolved
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/mercury/streams/streams.go
Outdated
Show resolved
Hide resolved
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/mercury/streams/streams.go
Outdated
Show resolved
Hide resolved
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/mercury/streams/streams.go
Show resolved
Hide resolved
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/mercury/streams/streams_test.go
Outdated
Show resolved
Hide resolved
|
infiloop2
merged commit ceec78a
into
auto-9004-stream-err-handler
113 of 115 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
TODO:
Will be done in feature branch