(feat): FUN-1234 Functions USD denominated premium fees #12104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
I see that you haven't updated any README files. Would it make sense to do so? |
KuphJr
previously approved these changes
Feb 20, 2024
KuphJr
previously approved these changes
Feb 20, 2024
justinkaseman
force-pushed
the
FUN-1234-clone
branch
from
081f663 to
de32975
Compare
KuphJr
approved these changes
Feb 20, 2024
|
bolekk
reviewed
Feb 21, 2024
| // The following line represents: "cost without callback or admin fee, those will be added by the Router" | ||
| // But because the _offchain_ Commitment is using operation fee in the place of the admin fee, this now adds admin fee (actually operation fee) | ||
| // Admin fee is configured to 0 in the Router | ||
| gasOverheadJuels + commitment.donFee + commitment.adminFee, |
There was a problem hiding this comment.
Alternatively we could have a variable named operationFee above (set to adminFee). Then this line will be clearer.
| donFeeJuels: commitment.donFee, | ||
| // The following two lines are because of OperationFee being used in the Offchain Commitment | ||
| adminFeeJuels: 0, | ||
| operationFeeJuels: commitment.adminFee |
There was a problem hiding this comment.
if we had that helper variable we could use it here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.