Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TXM In-memory: add address state framework : STEP 2 #12122

Closed
wants to merge 25 commits into from
Closed

TXM In-memory: add address state framework : STEP 2 #12122

wants to merge 25 commits into from

Conversation

poopoothegorilla
Copy link
Contributor

@poopoothegorilla poopoothegorilla commented Feb 21, 2024 •
edited
Loading

This PR adds the initial framework for the AddressState which will be responsible for holding all the transaction states for a given Address.

Parent PR:

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

patrick-dowell
patrick-dowell reviewed Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@patrick-dowell patrick-dowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, but otherwise looks reasonable to me.

common/txmgr/address_state.go Outdated Show resolved Hide resolved
@poopoothegorilla poopoothegorilla mentioned this pull request Feb 23, 2024
Closed
@poopoothegorilla poopoothegorilla mentioned this pull request Feb 26, 2024
Closed
prashantkumar1982
prashantkumar1982 reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@prashantkumar1982 prashantkumar1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can approve with minor changes.

patrick-dowell
patrick-dowell reviewed Mar 9, 2024
View reviewed changes
common/txmgr/address_state.go
case TxFatalError:
as.fatalErroredTxs[tx.ID] = &tx
default:
panic("unknown transaction state")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prashantkumar1982 @poopoothegorilla does panic make sense here? I doubt we will ever hit this, but if by some miracle we do, wouldn't it be better to just drop the TX, log it, and proceed? Or is this error only possible through some sort of dev error that we want to catch ASAP?

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)
20 New Major Issues (required ≤ 5)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 21, 2024
@github-actions github-actions bot closed this May 29, 2024
@amit-momin amit-momin reopened this Jun 26, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 28, 2024
@github-actions github-actions bot closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amit-momin amit-momin amit-momin left review comments

@prashantkumar1982 prashantkumar1982 prashantkumar1982 left review comments

@patrick-dowell patrick-dowell patrick-dowell left review comments

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@poopoothegorilla @patrick-dowell @prashantkumar1982 @amit-momin