-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix losing batch call errors for individual requests #12127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
poopoothegorilla
previously approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it fixes the issue that @dimriou raised
jmank88
reviewed
Feb 22, 2024
jmank88
reviewed
Feb 22, 2024
jmank88
approved these changes
Feb 22, 2024
Quality Gate passedIssues Measures |
dimriou
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
BatchElem.Error
field. DocumentationBatchElem
is not populated with the error because the existing code casts the requests into an array ofany
in the multinode code then back toBatchElem
in the rpc client code.Solution
BatchElem
type to the multinode and rpc client interfacesBatchCallContext
andBatchCallContextAll
methods to directly take theBatchElem
as a parameterBatchElem
toany
then back allowing the original request passed in to be populated with individual errors to be used by the caller