Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Forwarder ORM #12131

Merged
merged 11 commits into from
Feb 23, 2024
Merged

Refactor Forwarder ORM #12131

merged 11 commits into from
Feb 23, 2024

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Feb 21, 2024 •
edited
Loading

Refactor ORM to remove dependency on core/services/pg and Q type.

@DylanTinianov DylanTinianov changed the title Bci 2644 refactor forwarder orm Refactor Forwarder ORM Feb 21, 2024
@DylanTinianov DylanTinianov self-assigned this Feb 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@DylanTinianov DylanTinianov marked this pull request as ready for review February 21, 2024 21:38
@DylanTinianov DylanTinianov requested review from a team as code owners February 21, 2024 21:38
poopoothegorilla
poopoothegorilla reviewed Feb 22, 2024
View reviewed changes
@DylanTinianov DylanTinianov requested a review from a team as a code owner February 23, 2024 14:54
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@DylanTinianov DylanTinianov merged commit eeda137 into BCI-2644-refactor-evm-orms Feb 23, 2024
106 checks passed
@DylanTinianov DylanTinianov deleted the BCI-2644-refactor-forwarder-orm branch February 23, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimriou dimriou dimriou approved these changes

@amit-momin amit-momin amit-momin approved these changes

@poopoothegorilla poopoothegorilla Awaiting requested review from poopoothegorilla

@jmank88 jmank88 Awaiting requested review from jmank88

Assignees

@DylanTinianov DylanTinianov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DylanTinianov @jmank88 @poopoothegorilla @dimriou @amit-momin