core/chains/evm/client: eth_call: include duplicate legacy field for compatability #12140
Conversation
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
force-pushed
the
eth_call-input-data
branch
from
98d9a74 to
70e9296
Compare
core/chains/evm/client/rpc_client.go
Outdated
| } | ||
| if len(msg.Data) > 0 { | ||
| arg["input"] = hexutil.Bytes(msg.Data) | ||
| arg["data"] = hexutil.Bytes(msg.Data) // duplicate legacy field for compatability |
There was a problem hiding this comment.
This is interesting - so geth included these before and has now removed it in the latest version. Is that correct?
There was a problem hiding this comment.
This is indeed nonstandard: https://ethereum.org/en/developers/docs/apis/json-rpc#eth_call
There was a problem hiding this comment.
The server for a long time has accepted both (>6 years?), and they recently switched the client from data to input.
|
|
||
| // COPIED FROM go-ethereum/ethclient/gethclient - must be kept up to date! |
There was a problem hiding this comment.
What commit sha of go-ethereum was this copied from?
There was a problem hiding this comment.
The one that is imported in the go.mod
jmank88
force-pushed
the
eth_call-input-data
branch
from
70e9296 to
2a1126e
Compare
jmank88
force-pushed
the
eth_call-input-data
branch
from
2a1126e to
f83f128
Compare
|
|
||
| // COPIED FROM go-ethereum/ethclient/gethclient - must be kept up to date! | ||
| // Modified to include legacy 'data' as well as 'input' in order to support non-compliant servers. | ||
| func toCallArg(msg ethereum.CallMsg) interface{} { |
There was a problem hiding this comment.
@jmank88 ethereum recently updated this function to and added extra fields, should we reflect those changes?
https://github.com/ethereum/go-ethereum/blob/master/ethclient/ethclient.go#L642
There was a problem hiding this comment.
nvm 1.13.8 doesnot use it, just need to ensure we update this function if we do modify to new geth version
There was a problem hiding this comment.
I copied from the version we import to minimize changes
jmank88
force-pushed
the
eth_call-input-data
branch
from
f83f128 to
464fdd5
Compare
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
No description provided.