-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set log buffer limits via the log provider config #12152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
ferglor
force-pushed
the
feature/AUTO-9023
branch
from
February 23, 2024 11:18
cc26ca3
to
28c3533
Compare
ferglor
force-pushed
the
feature/AUTO-9023
branch
from
February 23, 2024 11:25
979c0b5
to
85d4fb2
Compare
ferglor
force-pushed
the
feature/AUTO-9023
branch
from
February 23, 2024 11:58
85d4fb2
to
4ec48f6
Compare
ferglor
force-pushed
the
feature/AUTO-9023
branch
from
February 23, 2024 12:28
4ec48f6
to
eef2f4d
Compare
reductionista
force-pushed
the
fix/migration-pg14-dep
branch
from
February 23, 2024 19:32
6ab96de
to
ef95fe2
Compare
ferglor
force-pushed
the
feature/AUTO-9023
branch
from
February 26, 2024 14:08
5f9bede
to
fb63653
Compare
ferglor
force-pushed
the
feature/AUTO-9023
branch
from
February 26, 2024 19:02
dc19013
to
d96b9e2
Compare
ferglor
force-pushed
the
feature/AUTO-9023
branch
from
March 28, 2024 15:15
df767f1
to
4dcc367
Compare
ferglor
force-pushed
the
feature/AUTO-9023
branch
from
March 29, 2024 12:23
4e5c212
to
f2c737d
Compare
ferglor
force-pushed
the
feature/AUTO-9023
branch
from
April 1, 2024 15:15
f5566cb
to
6762065
Compare
amirylm
previously approved these changes
Apr 1, 2024
Store default block rates and log limits on the log buffer Revert buffer changes, calculate default values in the provider and pass to the buffer for now go mod tidy Move the default block rate and log limits into their own functions Update tests Update tests Update tests Keep buffer unchanged, update tests Update tests Bump automation Bump automation Keep buffer.go as-is for now Update constructor Update changeset Bump automation and common
ferglor
force-pushed
the
feature/AUTO-9023
branch
from
April 1, 2024 17:54
bdcdbd4
to
2fb7521
Compare
Quality Gate passedIssues Measures |
ogtownsend
approved these changes
Apr 1, 2024
amirylm
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/AUTO-9023
In this PR, we're implementing the new
SetConfig
function on theLogEventProvider
type. When called, the passed config struct is read, and the values are passed into theSetConfig
function on thelogEventBuffer
type. The log buffer performs checks to ensure that if zero values are passed, we fall back to the default values for each config value.Related PRs
Testing
The following tests were conducted through integration tests developed by @anirudhwarrier 🎉 🙏 🙌 ; the code samples are excerpts from a go codebase tasked with calling SetConfig on a deployed registry running against the code in this PR. The log samples are from grafana.
SetConfig with non-zero values in LogProviderConfig
When SetConfig in the provider is called with non-zero values:
SetConfig in the log buffer uses the off chain config values:
SetConfig with missing LogProviderConfig
When SetConfig in the provider is called with zero values:
SetLimits in the log buffer uses the default values: