Skeleton Implementation of Solana Chain Reader Service #12163
Conversation
This commit adds a new package that contains a limited chain reader for solana that implements the basic interfaces of `ServiceCtx` and `ChainReader`. All functions required for `ServiceCtx` are complete and included in a test. All functions required for `ChainReader` return an 'unimplemented' error.
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
| } | ||
|
|
||
| var ( | ||
| ErrUnimplemented = errors.New("function unimplemented") |
There was a problem hiding this comment.
There is a types.UnimplementedError type you should be able to import from chainlink-comon.
You can use it like:
types.UnimplementedError("custom error message")
|
The code looks fine so far, but instead of here it should go in the evm is special in that, it's the only relay that's still in core--we plan to move it into its own repo soon, the others already each have their own repo |
|
Moving to |
This commit adds a new package that contains a limited chain reader for solana that implements the basic interfaces of
ServiceCtxandChainReader. All functions required forServiceCtxare complete and included in a test. All functions required forChainReaderreturn an 'unimplemented' error.