Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get cross platform + goreleaser working for devspace #12166

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Get cross platform + goreleaser working for devspace #12166

merged 3 commits into from
Mar 4, 2024

Conversation

HenryNguyen5
Copy link
Collaborator

@HenryNguyen5 HenryNguyen5 commented Feb 24, 2024 •
edited by scheibinger
Loading

Using goreleaser to build cross platform binaries and docker images in devspace configuration.

Why

  • The default mechanism for building in devspace using docker was unreliable. From time to time it was building incorrect architecture even though it was specified via env variable.

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@HenryNguyen5 HenryNguyen5 force-pushed the chore/crib_devspace_cross_platform branch from 3f0acb1 to 8f917b7 Compare March 1, 2024 02:08
@scheibinger scheibinger force-pushed the chore/crib_devspace_cross_platform branch from 8f917b7 to 0b70fad Compare March 1, 2024 15:35
@scheibinger scheibinger marked this pull request as ready for review March 4, 2024 12:01
@scheibinger scheibinger requested review from skudasov and a team March 4, 2024 12:01
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@skudasov skudasov added this pull request to the merge queue Mar 4, 2024
Merged via the queue into develop with commit 2f73d04 Mar 4, 2024
98 checks passed
@skudasov skudasov deleted the chore/crib_devspace_cross_platform branch March 4, 2024 17:05
scheibinger added a commit to smartcontractkit/ccip that referenced this pull request Mar 5, 2024
@scheibinger
Build dockers with goreleaser
af8dff1 
Porting the change from chainlink core: smartcontractkit/chainlink#12166 to make cross platform build more reliable.
It required to update nix flake dependencies, so we can use the latest version of goreleaser.

ref: https://smartcontract-it.atlassian.net/browse/RE-2345
@scheibinger scheibinger mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skudasov skudasov skudasov approved these changes

@momentmaker momentmaker momentmaker approved these changes

@chainchad chainchad Awaiting requested review from chainchad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HenryNguyen5 @momentmaker @skudasov @scheibinger