Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golangci-lint: add depguard to disallow modules #12200

Merged
merged 1 commit into from
Mar 5, 2024
Merged

golangci-lint: add depguard to disallow modules #12200

merged 1 commit into from
Mar 5, 2024

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Feb 27, 2024 •
edited
Loading

This PR enabled the depgaurd golangci-lint check, to block use of some modules.

Replaces: #11697

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

poopoothegorilla
poopoothegorilla previously approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@poopoothegorilla poopoothegorilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jmank88 jmank88 requested a review from archseer February 28, 2024 12:55
@jmank88 jmank88 marked this pull request as ready for review March 4, 2024 14:19
@jmank88 jmank88 requested review from a team as code owners March 4, 2024 14:19
samsondav
samsondav previously approved these changes Mar 4, 2024
View reviewed changes
@jmank88 jmank88 requested a review from a team as a code owner March 4, 2024 14:49
@jmank88 jmank88 enabled auto-merge March 4, 2024 14:49
@jmank88 jmank88 requested a review from samsondav March 4, 2024 14:50
patrickhuie19
patrickhuie19 previously approved these changes Mar 4, 2024
View reviewed changes
@jmank88 jmank88 dismissed stale reviews from poopoothegorilla and patrickhuie19 via b67b64f March 5, 2024 13:27
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@jmank88 jmank88 added this pull request to the merge queue Mar 5, 2024
Merged via the queue into develop with commit 1f16d03 Mar 5, 2024
97 checks passed
@jmank88 jmank88 deleted the depguard branch March 5, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@archseer archseer Awaiting requested review from archseer

@samsondav samsondav Awaiting requested review from samsondav

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

@poopoothegorilla poopoothegorilla Awaiting requested review from poopoothegorilla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmank88 @samsondav @poopoothegorilla @patrickhuie19 @aalu1418