Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default for logs_per_block & max_logs_kept columns from NULL to 0 #12213

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

reductionista
Copy link
Contributor

@reductionista reductionista commented Feb 28, 2024

During PR review of #11949, we decided to change the types of [ max_logs_kept / MaxLogsKept ]
and[ logs_per_block / LogsPerBlock ] from [ NUMERIC / *big.Int ] to [ BIGINT / uint64 ]. I intended the default value to be 0 now instead of NULL,
but forgot to add the corresponding NOT NULL DEFAULT 0 clause to these columns in the db schema

type Filter struct {
...
	MaxLogsKept  uint64             // maximum number of logs to retain ( 0 = unlimited )
	LogsPerBlock uint64             // rate limit ( maximum # of logs per block, 0 = unlimited )
}

Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@reductionista reductionista marked this pull request as ready for review February 28, 2024 23:50
@reductionista reductionista requested a review from a team as a code owner February 28, 2024 23:50
@cl-sonarqube-production
Copy link

@reductionista reductionista added this pull request to the merge queue Feb 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 29, 2024
@reductionista reductionista added this pull request to the merge queue Feb 29, 2024
Merged via the queue into develop with commit df03e3b Feb 29, 2024
97 checks passed
@reductionista reductionista deleted the fix/logs_per_block_default branch February 29, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants