TXM In-memory: step 3-01-SaveSentAttempt

[poopoothegorilla]

NOTES:

• Implements SaveSentAttempt

Parent:

• TXM In-memory: address_state methods: step 3-01 #12177

[github-actions]

I see that you haven't updated any README files. Would it make sense to do so?

[DylanTinianov]

Nit: Can avoid indexing

Suggested change

	for i := range tx.TxAttempts {
	if tx.TxAttempts[i].ID == attempt.ID {
	tx.TxAttempts[i].State = txmgrtypes.TxAttemptBroadcast
	return
	}
	}
	for _, txAttempt := range tx.TxAttempts {
	if txAttempt.ID == attempt.ID {
	txAttempt.State = txmgrtypes.TxAttemptBroadcast
	return
	}
	}

[poopoothegorilla]

great find! will switch to the for i :=0; i < _ ; i++ syntax to prevent the linter from complaining :)

[DylanTinianov]

Small nit, looks good though

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube