Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TXM In-memory: step 3-04-UpdateTxFatalError #12226

Merged
merged 6 commits into from
Apr 4, 2024
Merged

TXM In-memory: step 3-04-UpdateTxFatalError #12226

merged 6 commits into from
Apr 4, 2024

Conversation

poopoothegorilla
Copy link
Contributor

NOTES:

  • Implements UpdateTxFatalError

Parent:

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@poopoothegorilla poopoothegorilla marked this pull request as ready for review April 1, 2024 22:45
@poopoothegorilla poopoothegorilla requested a review from a team as a code owner April 1, 2024 22:45
DylanTinianov
DylanTinianov approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@DylanTinianov DylanTinianov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Amit on checking if the tx exists. Otherwise looks good, will approve.

@poopoothegorilla poopoothegorilla merged commit 09e6d61 into jtw/step-3-04 Apr 4, 2024
54 of 58 checks passed
@poopoothegorilla poopoothegorilla deleted the jtw/step-3-04-update-tx-fatal-error branch April 4, 2024 13:23
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amit-momin amit-momin amit-momin left review comments

@DylanTinianov DylanTinianov DylanTinianov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poopoothegorilla @DylanTinianov @amit-momin