Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TXM In-memory: step 3-03-SaveFetchedReceipts #12229

Merged
merged 7 commits into from
Apr 4, 2024
Merged

TXM In-memory: step 3-03-SaveFetchedReceipts #12229

merged 7 commits into from
Apr 4, 2024

Conversation

poopoothegorilla
Copy link
Contributor

NOTES:

  • Implements SaveFetchedReceipts

Parent:

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@poopoothegorilla poopoothegorilla marked this pull request as ready for review April 3, 2024 19:36
@poopoothegorilla poopoothegorilla requested a review from a team as a code owner April 3, 2024 19:36
amit-momin
amit-momin reviewed Apr 3, 2024
View reviewed changes
common/txmgr/address_state.go
@@ -350,6 +350,8 @@ func (as *addressState[CHAIN_ID, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE]) moveTx
txAttempt.BroadcastBeforeBlockNum = &blockNum
}
tx.State = TxConfirmed
as.confirmedTxs[tx.ID] = tx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm here too that tx are only moved from Unconfirmed to Confirmed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@poopoothegorilla poopoothegorilla merged commit fa0ff89 into jtw/step-3-03 Apr 4, 2024
109 of 114 checks passed
@poopoothegorilla poopoothegorilla deleted the jtw/step-3-03-save-fetched-receipts branch April 4, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amit-momin amit-momin amit-momin approved these changes

@DylanTinianov DylanTinianov Awaiting requested review from DylanTinianov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poopoothegorilla @DylanTinianov @amit-momin