Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LOOP Plugin support to CRIB devspace images #12350

Merged
merged 8 commits into from
Mar 13, 2024
Merged

Add LOOP Plugin support to CRIB devspace images #12350

merged 8 commits into from
Mar 13, 2024

Conversation

HenryNguyen5
Copy link
Contributor

@HenryNguyen5 HenryNguyen5 commented Mar 7, 2024 •
edited
Loading

  • Introduce LOOP plugin support for devspace goreleaser builds

@HenryNguyen5 HenryNguyen5 requested a review from a team as a code owner March 7, 2024 22:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

I see you updated files related to core. Please run pnpm changeset to add a changeset.

@HenryNguyen5 HenryNguyen5 force-pushed the chore/crib_loop_plugins branch 2 times, most recently from 06c1365 to c01f633 Compare March 11, 2024 18:01
@HenryNguyen5 HenryNguyen5 force-pushed the chore/crib_loop_plugins branch from c01f633 to 17e7351 Compare March 11, 2024 18:04
@HenryNguyen5 HenryNguyen5 force-pushed the chore/crib_loop_plugins branch from 17e7351 to e76836f Compare March 11, 2024 18:08
@HenryNguyen5 HenryNguyen5 requested review from a team and skudasov March 11, 2024 18:08
jmank88
jmank88 previously approved these changes Mar 11, 2024
View reviewed changes
chainchad
chainchad previously approved these changes Mar 12, 2024
View reviewed changes
@chainchad chainchad enabled auto-merge March 12, 2024 15:21
@HenryNguyen5 HenryNguyen5 dismissed stale reviews from chainchad and jmank88 via c850d66 March 12, 2024 21:29
@HenryNguyen5 HenryNguyen5 requested a review from a team as a code owner March 12, 2024 21:29
@HenryNguyen5 HenryNguyen5 force-pushed the chore/crib_loop_plugins branch from c850d66 to 0916f44 Compare March 12, 2024 21:31
chainchad
chainchad requested changes Mar 12, 2024
View reviewed changes
tools/bin/goreleaser_utils Show resolved Hide resolved
tools/bin/goreleaser_utils Outdated Show resolved Hide resolved
@HenryNguyen5 HenryNguyen5 requested a review from a team as a code owner March 13, 2024 13:32
@HenryNguyen5 HenryNguyen5 requested a review from chainchad March 13, 2024 14:26
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@chainchad chainchad added this pull request to the merge queue Mar 13, 2024
Merged via the queue into develop with commit 310e936 Mar 13, 2024
98 checks passed
@chainchad chainchad deleted the chore/crib_loop_plugins branch March 13, 2024 15:56
ogtownsend pushed a commit that referenced this pull request Mar 14, 2024
@HenryNguyen5 @chainchad
@momentmaker @ogtownsend
Add LOOP Plugin support to CRIB devspace images (#12350)
40ad4bf 
* Introduce LOOP plugin support for devspace goreleaser builds

* Ignore core dockerfile

* update ci changesets filtering

* update paths-filter version

* split shared to its own check and add pnpm .tool-versions

* Address feedback

---------

Co-authored-by: chainchad <[email protected]>
Co-authored-by: Frank Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chainchad chainchad chainchad approved these changes

@skudasov skudasov Awaiting requested review from skudasov

@jmank88 jmank88 Awaiting requested review from jmank88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HenryNguyen5 @jmank88 @chainchad @momentmaker