Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KS-86] Add handler to execute single step #12394

Merged
merged 3 commits into from
Mar 15, 2024
Merged

[KS-86] Add handler to execute single step #12394

merged 3 commits into from
Mar 15, 2024

Conversation

cedric-cordenier
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@cedric-cordenier cedric-cordenier force-pushed the KS-86-Handler-to-execute-single-step branch from 56f0c02 to 1f3531c Compare March 12, 2024 18:09
@cedric-cordenier cedric-cordenier force-pushed the KS-86-Handler-to-execute-single-step branch from 1f3531c to 85ecce8 Compare March 13, 2024 10:47
@cedric-cordenier cedric-cordenier changed the title Ks 86 handler to execute single step [KS-86] Add handler to execute single step Mar 13, 2024
@cedric-cordenier cedric-cordenier marked this pull request as ready for review March 13, 2024 10:51
@cedric-cordenier cedric-cordenier requested a review from a team as a code owner March 13, 2024 10:51
@cedric-cordenier cedric-cordenier force-pushed the KS-86-Handler-to-execute-single-step branch from 4119208 to 87bff14 Compare March 13, 2024 11:27
bolekk
bolekk reviewed Mar 14, 2024
View reviewed changes
core/services/workflows/state.go Show resolved Hide resolved
core/services/workflows/state.go Outdated Show resolved Hide resolved
core/services/workflows/state.go Show resolved Hide resolved
core/services/workflows/state.go Show resolved Hide resolved
core/services/workflows/state.go Outdated Show resolved Hide resolved
core/services/workflows/state_test.go Show resolved Hide resolved
core/services/workflows/engine.go Show resolved Hide resolved
core/services/workflows/engine.go Show resolved Hide resolved
core/services/workflows/engine.go Show resolved Hide resolved
@cedric-cordenier cedric-cordenier force-pushed the KS-86-Handler-to-execute-single-step branch from 00e772c to af914a1 Compare March 14, 2024 15:39
bolekk
bolekk previously approved these changes Mar 15, 2024
View reviewed changes
core/services/workflows/engine.go Show resolved Hide resolved
@cedric-cordenier cedric-cordenier force-pushed the KS-86-Handler-to-execute-single-step branch from 5419f11 to 01628b7 Compare March 15, 2024 11:22
@cedric-cordenier cedric-cordenier requested a review from a team as a code owner March 15, 2024 11:22
@cedric-cordenier cedric-cordenier requested a review from bolekk March 15, 2024 11:23
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
4 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
90.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@cedric-cordenier cedric-cordenier added this pull request to the merge queue Mar 15, 2024
Merged via the queue into develop with commit 65f7acd Mar 15, 2024
97 of 98 checks passed
@cedric-cordenier cedric-cordenier deleted the KS-86-Handler-to-execute-single-step branch March 15, 2024 12:02
cedric-cordenier added a commit that referenced this pull request Mar 18, 2024
@cedric-cordenier
[KS-86] Add handler to execute single step (#12394)
12b8a48 
* Add hardcoded YAML workflow and parsing

* Execute an individual step

* Execute an individual step
@HenryNguyen5 HenryNguyen5 mentioned this pull request Mar 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 22, 2024
@cedric-cordenier @HenryNguyen5
[KS-87] Generic workflow engine (#12461)
4fe2e77 
* [KS-86] Add handler to execute single step (#12394)

* Add hardcoded YAML workflow and parsing

* Execute an individual step

* Execute an individual step

* Execute an individual step

* [KS-87] Add scheduler to workflow engine

* Replace graph with graph lib

* Add comments and renames

* Replace graph with graph lib

---------

Co-authored-by: HenryNguyen5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@george-dorin george-dorin george-dorin approved these changes

@HenryNguyen5 HenryNguyen5 Awaiting requested review from HenryNguyen5

@krehermann krehermann Awaiting requested review from krehermann

@bolekk bolekk Awaiting requested review from bolekk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cedric-cordenier @bolekk @krehermann @george-dorin