use gomods #12429
Merged
use gomods #12429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
jmank88
commented
Mar 14, 2024
Comment on lines
-31
to
-34
| go mod tidy | ||
| cd ./core/scripts && go mod tidy | ||
| cd ./integration-tests && go mod tidy | ||
| cd ./integration-tests/load && go mod tidy |
There was a problem hiding this comment.
Notice this was missing two modules:
go install github.com/jmank88/[email protected]
gomods -w go generate -x ./...
found 6 go.mod files:
./go.mod
charts/chainlink-cluster/go.mod
core/scripts/go.mod
dashboard/go.mod
integration-tests/go.mod
integration-tests/load/go.mod
There was a problem hiding this comment.
(and one was not tidy)
jmank88
commented
Mar 14, 2024
| generate: abigen codecgen mockery protoc ## Execute all go:generate commands. | ||
| go generate -x ./... | ||
| generate: abigen codecgen mockery protoc gomods ## Execute all go:generate commands. | ||
| gomods -w go generate -x ./... |
There was a problem hiding this comment.
We were only generating the core module.
chainchad
previously approved these changes
Mar 14, 2024
|
vyzaldysanchez
approved these changes
Mar 15, 2024
chainchad
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
gomodsso we don't have to keep updating our commands with a hard coded list of modules.https://github.com/jmank88/gomods