Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-974] Chainlink-evm workflow dispatch updates #12457

Merged
merged 10 commits into from
Mar 18, 2024

Conversation

tateexon
Copy link
Contributor

Fix up the ci-core and integration-tests workflows to work with the GATI workflow dispatch from chainlink-evm

Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@tateexon tateexon marked this pull request as ready for review March 16, 2024 16:56
@tateexon tateexon requested review from a team as code owners March 16, 2024 16:56
@tateexon tateexon enabled auto-merge March 18, 2024 15:43
@@ -1,7 +1,8 @@
name: CI Core
run-name: CI Core ${{ inputs.distinct_run_name && inputs.distinct_run_name || '' }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distinct_run_name usage is required here to properly find the running workflow after it has kicked off. Without this there is a chance we grab the wrong one when the repo is running workflows for several PRs around the same time. Github doesn't provide a built in way to get this in the api when doing a workflow_dispatch so we have to work around that.


concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
group: ${{ github.workflow }}-${{ github.ref }}-${{ inputs.distinct_run_name }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this here so if chainlink-evm pushes two PRs that run these tests around the same time in the future they don't collide with the last one in winning.

.github/workflows/ci-core.yml Outdated Show resolved Hide resolved
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@tateexon tateexon added this pull request to the merge queue Mar 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2024
@tateexon tateexon added this pull request to the merge queue Mar 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2024
@tateexon tateexon added this pull request to the merge queue Mar 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2024
@tateexon tateexon added this pull request to the merge queue Mar 18, 2024
Merged via the queue into develop with commit 331c1cb Mar 18, 2024
178 checks passed
@tateexon tateexon deleted the tate_reusable_e2e_part2 branch March 18, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants