-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-974] Chainlink-evm workflow dispatch updates #12457
Conversation
I see that you haven't updated any README files. Would it make sense to do so? |
067a2ee
to
4f31e55
Compare
4f31e55
to
60e6616
Compare
@@ -1,7 +1,8 @@ | |||
name: CI Core | |||
run-name: CI Core ${{ inputs.distinct_run_name && inputs.distinct_run_name || '' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The distinct_run_name usage is required here to properly find the running workflow after it has kicked off. Without this there is a chance we grab the wrong one when the repo is running workflows for several PRs around the same time. Github doesn't provide a built in way to get this in the api when doing a workflow_dispatch so we have to work around that.
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.ref }} | ||
group: ${{ github.workflow }}-${{ github.ref }}-${{ inputs.distinct_run_name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this here so if chainlink-evm pushes two PRs that run these tests around the same time in the future they don't collide with the last one in winning.
Quality Gate passedIssues Measures |
Fix up the ci-core and integration-tests workflows to work with the GATI workflow dispatch from chainlink-evm