Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracted Gas Limit Multiplier from gas estimators to WrappedEvmEstimator #12534

Merged
merged 37 commits into from
Mar 28, 2024
Merged

Extracted Gas Limit Multiplier from gas estimators to WrappedEvmEstimator #12534

merged 37 commits into from
Mar 28, 2024

Conversation

silaslenihan
Copy link
Contributor

@silaslenihan silaslenihan commented Mar 21, 2024 •
edited
Loading

Previously, the gas limit multiplier was applied within each specific gas estimator. This PR extracts that logic to be carried out by WrappedEvmEstimator, enabled a simplified, all-encompassing calculation.

@silaslenihan silaslenihan requested a review from a team as a code owner March 21, 2024 19:59
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset.

FelixFan1992 and others added 2 commits March 21, 2024 19:38
@FelixFan1992 @RyanRHall @silaslenihan
improve some nits and refactor foundry tests (#12522)
cf9002e 
* improve some nits and refactor foundry tests

* add changesets

* fix

* fix tests

* write registerUpkeep() foundry tests for auto v2.3 (#12535)

move addFunds() tests to foundry for auto v2.3

add tests for onTokenTransfer()

---------

Co-authored-by: Ryan Hall <[email protected]>
@silaslenihan
Added error checks
933524f
@silaslenihan silaslenihan requested review from a team and RensR as code owners March 21, 2024 23:38
@silaslenihan silaslenihan force-pushed the BCI-2702-Apply-LimitMultiplier-to-gas-limit-in-all-gas-estimators branch from 1e58dc0 to ec51b7b Compare March 21, 2024 23:39
@silaslenihan silaslenihan force-pushed the BCI-2702-Apply-LimitMultiplier-to-gas-limit-in-all-gas-estimators branch from ec51b7b to 58f0336 Compare March 22, 2024 00:18
amit-momin
amit-momin previously approved these changes Mar 22, 2024
View reviewed changes
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
87.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@dimriou dimriou added this pull request to the merge queue Mar 28, 2024
Merged via the queue into develop with commit bd532b5 Mar 28, 2024
102 checks passed
@dimriou dimriou deleted the BCI-2702-Apply-LimitMultiplier-to-gas-limit-in-all-gas-estimators branch March 28, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantkumar1982 prashantkumar1982 prashantkumar1982 left review comments

@amit-momin amit-momin amit-momin approved these changes

@dimriou dimriou dimriou approved these changes

@RensR RensR Awaiting requested review from RensR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@silaslenihan @dimriou @prashantkumar1982 @amit-momin @FelixFan1992