Changes to the LDAP authentication driver #12542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CL-Andrew
commented
Mar 22, 2024
CL-Andrew
commented
- Conform duration type for QueryTimeout in LDAP config struct
- Fix typo in config parsing error message on EditUserGroupCN required and not set
- Remove duplicate code block
- Add config validations for LDAP fields where applicable for config file parameterized values
- Fix logic for local admin authentication fallback when there is an email key clash in both the upstream ldap server and the local users table, FindUser now follows the same user source precedence
- Comment clarity for FindUser guarantees
- Added additional WHERE clause to explicitly select admin users to enforce LDAP module guarantees
|
I see you updated files related to |
jmank88
previously approved these changes
Mar 22, 2024
CL-Andrew
changed the title
Comform duration type for QueryTimeout in LDAP config struct Fix typo in config parsing error message on EditUserGroupCN required and not set Remove duplicate code block Add config validations for LDAP fields where applicable for config file parameterized values Fix logic for local admin authentication fallback when there is an email key clash in both the upstream ldap server and the local users table, FindUser now follows the same user source precedence Comment clarity for FindUser guarantees Added additional WHERE clause to explicitly select admin users to enforce LDAP module guarantees
|
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.