Auto 9427 withdraw erc 20 fees does not check reserve amount #12582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shileiwill
reviewed
Mar 25, 2024
| _onlyFinanceAdminAllowed(); | ||
| if (to == ZERO_ADDRESS) revert InvalidRecipient(); | ||
| uint256 available = asset.balanceOf(address(this)) - s_reserveAmounts[asset]; | ||
| if (amount > available) revert InsufficientBalance(available, amount); |
shileiwill
previously approved these changes
Mar 25, 2024
RyanRHall
force-pushed
the
AUTO-9427-withdraw-erc-20-fees-does-not-check-reserve-amount
branch
from
b9d23be to
a4feec2
Compare
RyanRHall
force-pushed
the
AUTO-9427-withdraw-erc-20-fees-does-not-check-reserve-amount
branch
from
a4feec2 to
b546312
Compare
|
| @@ -4636,7 +4636,7 @@ describe('AutomationRegistry2_3', () => { | |||
| describe('#withdrawOwnerFunds', () => { | |||
There was a problem hiding this comment.
should we update this test name?
FelixFan1992
approved these changes
Mar 26, 2024
RyanRHall
deleted the
AUTO-9427-withdraw-erc-20-fees-does-not-check-reserve-amount
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.