Trailing slash #12606
Merged
Trailing slash #12606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
shileiwill
force-pushed
the
trailing-slash
branch
from
8d622f6 to
e368bd4
Compare
jmank88
reviewed
Mar 26, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/registry.go
Outdated
Show resolved
Hide resolved
|
jmank88
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Actions seems all green: https://github.com/smartcontractkit/chainlink/actions/runs/8443994562/job/23128794765
I ran
go test -race -run TestCredentials_RemoveTrailingSlashin my local and pass.Let me know anything else to test.